python icon indicating copy to clipboard operation
python copied to clipboard
verified publisher icon kubernetes-client

google-auth Made as optional dependency

Open shivanand007 opened this issue 1 year ago • 11 comments

What type of PR is this?

/kind feature

What this PR does / why we need it:

Makes Google auth as optional dependency, gives users a option to install it separately.

Which issue(s) this PR fixes:

Fixes #2249

Special notes for your reviewer:

Does this PR introduce a user-facing change?

This change modifies the `setup.py` file to move `google-auth` to the `extras_require` section,
allowing it to be installed with `pip install kubernetes[google-auth]`.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

shivanand007 avatar Oct 08 '24 09:10 shivanand007

Please add a release note with instructions of how to install google-auth going forward.

--> I have added the required release note, kindly have a review for the same.

We should also make sure the tests pass. I wonder if we need to update the test pipeline to install google-auth as well.

--> Yes, As we have Removed google-auth from requirements.txt, This must be a dependency in code which makes test cases to fail, I will check the code and see if we can make those code blocks optional as well, Additionally we have to update the test pipeline to test this use case.

/retest

shivanand007 avatar Oct 09 '24 09:10 shivanand007

@roycaihw I have made the necessary changes in code to make google-auth as optional, Requesting to Change Test Pipeline, So That we can pass all the E2E test Cases.

shivanand007 avatar Oct 09 '24 10:10 shivanand007

/retest

shivanand007 avatar Oct 12 '24 11:10 shivanand007

@shivanand007: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Oct 12 '24 11:10 k8s-ci-robot

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jan 10 '25 12:01 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Feb 09 '25 12:02 k8s-triage-robot

/remove-lifecycle rotten

mindw avatar Feb 10 '25 09:02 mindw

@roycaihw @yliaog Can we help review @shivanand007 's changes and retest please

darren-recentive avatar May 07 '25 08:05 darren-recentive

Sorry for the late reply.

/ok-to-test

roycaihw avatar May 13 '25 22:05 roycaihw

/retest

roycaihw avatar May 13 '25 22:05 roycaihw

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Aug 11 '25 23:08 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Sep 10 '25 23:09 k8s-triage-robot

/remove-lifecycle rotten

mindw avatar Sep 11 '25 06:09 mindw

Hello! What is the status of this PR? This change would be very much appreciated to get rid of google-auth as a mandatory dependency, since many use cases of this client does not require it.

kriszkern avatar Oct 10 '25 09:10 kriszkern

/lgtm /approve

yliaog avatar Oct 10 '25 19:10 yliaog

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shivanand007, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Oct 10 '25 19:10 k8s-ci-robot

Thanks @yliaog! Cheers!

kriszkern avatar Oct 10 '25 20:10 kriszkern