javascript icon indicating copy to clipboard operation
javascript copied to clipboard

Fix CVE in jsonpath-plus (again)

Open soniqua opened this issue 1 year ago • 3 comments

Describe the bug The jsonpath-plus dependency contains a critical CVE, even after upgrading to 10.0.0: CVE-2024-21534

The library has been fixed as of version 10.0.7 or higher.

There's an open dependabot PR for resolution.

** Client Version ** 0.22.1

Environment (please complete the following information):

  • NodeJS Client

Additional context

  • Previous fix: https://github.com/kubernetes-client/javascript/issues/1926

soniqua avatar Oct 21 '24 08:10 soniqua

@mstruebing Any idea on an ETA for a 0.22.x patch release?

timd73 avatar Oct 22 '24 08:10 timd73

No current eta, but probably within the week. fwiw, this library only uses this library for kubeconfig file loading. If you have malicious JSONPath in your kubeconfig, you have far worse problems than this RCE.

Also, unless your kubeconfig contains a jsonpath value you're not impacted by this CVE.

brendandburns avatar Oct 22 '24 16:10 brendandburns

@brendandburns thanks for the update/ETA, and for the added info.

FWIW, I am not concerned about the actual vulnerability, as I'd gathered that it's not truly exploitable. Rather it's about making the vulnerability scanners happy (remind me, do we work for them, or they for us?).

But good to know about how it impacts this library - thanks again!

timd73 avatar Oct 22 '24 18:10 timd73

@timd73 just pushed 0.22.2 to npm with the revised dependency.

brendandburns avatar Oct 31 '24 14:10 brendandburns

Hey I've noticed in our vulnerability scanners that this issues still persists in the 0.22.2 version of the package. Screenshot 2024-11-06 at 10 15 14 am

Think this package would also need to update the package.json to ^10.1.0 since the scanner looks at the package.json file for vulnerabilities

Thanks!

DeveloperAlan avatar Nov 05 '24 23:11 DeveloperAlan

That actually makes sense as it seems like we also don't publish our package-lock.json file. I don't think for a library it makes sense to publish a lock file, but in contrast that means we need to update our version ranges.

mstruebing avatar Nov 06 '24 08:11 mstruebing