docs icon indicating copy to clipboard operation
docs copied to clipboard

Seed and Master MLA customization uses outdated format

Open almereyda opened this issue 3 years ago • 17 comments

In the current documentation for customizing seed cluster MLAs

  • https://github.com/kubermatic/docs/blob/d9c713a3dd5e9cac10d0ad8f7f3944206f3f3747/content/kubermatic/v2.20/tutorials_howtos/monitoring_logging_alerting/master_seed/customization/_index.en.md

the "Customer-Cluster" (this is called User Cluster everywhere else) Prometheus is configured through a kubermatic.clusterNamespacePrometheus key, that is supposedly present in the seed's YAML.

Unfortunately that Key was only available and documented until v2.14,

  • https://www.google.com/search?q=%22clusterNamespacePrometheus%22+kubermatic

but is still mentioned in the documentation. As the keys are only offered through

  • https://github.com/kubermatic/kubermatic-installer/blob/release/v2.14/values.seed.example.yaml
  • https://github.com/kubermatic/kubermatic-installer/blob/release/v2.14/values.example.yaml

which appear very similar to those used in

  • https://github.com/kubermatic/kubermatic/blob/master/charts/seed.example.yaml

is it possible to reuse that key clusterNamespacePrometheus in the Seed spec to configure the userNamespacePrometheuses?

While the old installer repository is full of references to it:

  • https://github.com/kubermatic/kubermatic-installer/search?q=clusterNamespacePrometheus
  • https://github.com/kubermatic/kubermatic/search?q=clusterNamespacePrometheus

the new one doesn't know it anymore, and I am unsure where to put custom scraping rules for Prometheus for the user cluster MLA stack, and how to make sure that they propagate to the User Cluster MLA instances, esp. Prometheus here.

It appears this is nowadays done through the monitoring key in the configuration manifest, but remains undocumented:

  • https://github.com/kubermatic/kubermatic/blob/c95ebc2c20fe4d9ef4a7c3f31d2c0758b152f0bb/charts/kubermatic-operator/crd/k8c.io/kubermatic.k8c.io_kubermaticconfigurations.yaml#L488-L525
  • https://github.com/kubermatic/kubermatic/blob/56acaa8c339c5ef26324663ff93e7821fdb738a2/docs/zz_generated.kubermaticConfiguration.yaml#L425-L446

It appears this is partly related to

  • https://github.com/kubermatic/kubermatic/pull/8923
  • https://github.com/kubermatic/kubermatic/blob/master/docs/proposals/prometheus-operator.md

almereyda avatar Aug 03 '22 21:08 almereyda

Another way to bring in scraping configs, as do the kube-state-metrics and node-exporter plugins, seems to be through providing prometheus-scraping-* configmaps into the mla-system namespace.

apiVersion: v1
kind: ConfigMap
metadata:
  name: prometheus-scraping-postgres-operator
  namespace: mla-system
data:
  custom-scrape-configs.yaml: |
    ...

where we can add a similar YAML-formatted string as in the manifest.

almereyda avatar Aug 03 '22 21:08 almereyda

Issues go stale after 90d of inactivity. After a furter 30 days, they will turn rotten. Mark the issue as fresh with /remove-lifecycle stale.

If this issue is safe to close now please do so with /close.

/lifecycle stale

kubermatic-bot avatar Nov 02 '22 07:11 kubermatic-bot

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

kubermatic-bot avatar Dec 02 '22 07:12 kubermatic-bot

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

/close

kubermatic-bot avatar Jan 01 '23 07:01 kubermatic-bot

@kubermatic-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kubermatic-bot avatar Jan 01 '23 07:01 kubermatic-bot

/reopen /remove-lifecycle rotten

embik avatar Jan 19 '23 15:01 embik

@embik: Reopened this issue.

In response to this:

/reopen /remove-lifecycle rotten

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kubermatic-bot avatar Jan 19 '23 15:01 kubermatic-bot

Issues go stale after 90d of inactivity. After a furter 30 days, they will turn rotten. Mark the issue as fresh with /remove-lifecycle stale.

If this issue is safe to close now please do so with /close.

/lifecycle stale

kubermatic-bot avatar Apr 19 '23 19:04 kubermatic-bot

/remove-lifecycle stale

embik avatar Apr 24 '23 06:04 embik

@wurbanski can you maybe take a look at this if you have time and see what we need to fix and if it's still true?

embik avatar Apr 24 '23 06:04 embik

Issues go stale after 90d of inactivity. After a furter 30 days, they will turn rotten. Mark the issue as fresh with /remove-lifecycle stale.

If this issue is safe to close now please do so with /close.

/lifecycle stale

kubermatic-bot avatar Jul 23 '23 11:07 kubermatic-bot

/remove-lifecycle stale

embik avatar Jul 25 '23 06:07 embik

Issues go stale after 90d of inactivity. After a furter 30 days, they will turn rotten. Mark the issue as fresh with /remove-lifecycle stale.

If this issue is safe to close now please do so with /close.

/lifecycle stale

kubermatic-bot avatar Oct 23 '23 11:10 kubermatic-bot

/remove-lifecycle stale

embik avatar Oct 23 '23 15:10 embik

@embik this is the first time I see this 👀 will take a look

wurbanski avatar Oct 23 '23 15:10 wurbanski

Issues go stale after 90d of inactivity. After a furter 30 days, they will turn rotten. Mark the issue as fresh with /remove-lifecycle stale.

If this issue is safe to close now please do so with /close.

/lifecycle stale

kubermatic-bot avatar Jan 22 '24 00:01 kubermatic-bot

/remove-lifecycle stale

embik avatar Jan 22 '24 06:01 embik