website icon indicating copy to clipboard operation
website copied to clipboard

feat: Add Francisco as OWNER for Feature Store documentation

Open franciscojavierarceo opened this issue 1 year ago • 4 comments

Add Francisco as OWNER for Feature Store documentation

franciscojavierarceo avatar May 04 '24 18:05 franciscojavierarceo

Hi @franciscojavierarceo. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

google-oss-prow[bot] avatar May 04 '24 18:05 google-oss-prow[bot]

@andreyvelich @woop

franciscojavierarceo avatar May 04 '24 18:05 franciscojavierarceo

@Arhell any update here?

franciscojavierarceo avatar May 07 '24 20:05 franciscojavierarceo

Sorry, I don't have approval rights

Arhell avatar May 07 '24 20:05 Arhell

Np I also added a separate PR to add me to the org here: https://github.com/kubeflow/internal-acls/pull/679

franciscojavierarceo avatar May 07 '24 20:05 franciscojavierarceo

/approve

woop avatar May 09 '24 16:05 woop

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow[bot] avatar May 09 '24 16:05 google-oss-prow[bot]

@johnugeorge any chance you can review?

franciscojavierarceo avatar May 09 '24 17:05 franciscojavierarceo

/lgtm

rimolive avatar May 12 '24 12:05 rimolive

/verify-owners

rimolive avatar May 12 '24 12:05 rimolive