The case test_storage_account_creation failed in presummit integration

[jinchihe]

/kind bug

What steps did you take and what happened: The case test_storage_account_creation failed in presummit integration

Step #2: ________________________ test_storage_account_creation _________________________
Step #2: [gw0] linux -- Python 3.7.4 /usr/local/bin/python
Step #2:
Step #2:     def test_storage_account_creation():
Step #2:         credentials = ServicePrincipalCredentials(
Step #2:             client_id=os.environ.get('AZ_CLIENT_ID'),
Step #2:             secret=os.environ.get('AZ_CLIENT_SECRET'),
Step #2: >           tenant=os.environ.get('AZ_TENANT_ID')
Step #2:         )
Step #2:
Step #2: tests/fairing/integration/azure/test_azure_file_uploader.py:16:
Step #2: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
Step #2: /usr/local/lib/python3.7/site-packages/msrestazure/azure_active_directory.py:355: in __init__
Step #2:     self.set_token()
Step #2: /usr/local/lib/python3.7/site-packages/msrestazure/azure_active_directory.py:362: in set_token
Step #2:     super(ServicePrincipalCredentials, self).set_token()
Step #2: /usr/local/lib/python3.7/site-packages/msrestazure/azure_active_directory.py:188: in set_token
Step #2:     self._create_adal_context()
Step #2: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
Step #2:
Step #2: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
Step #2: /usr/local/lib/python3.7/site-packages/msrestazure/azure_active_directory.py:355: in __init__
Step #2:     self.set_token()
Step #2: /usr/local/lib/python3.7/site-packages/msrestazure/azure_active_directory.py:362: in set_token
Step #2:     super(ServicePrincipalCredentials, self).set_token()
Step #2: /usr/local/lib/python3.7/site-packages/msrestazure/azure_active_directory.py:188: in set_token
Step #2:     self._create_adal_context()
Step #2: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
Step #2:
Step #2: self = <msrestazure.azure_active_directory.ServicePrincipalCredentials object at 0x7f29b6ae0490>
Step #2:
Step #2:     def _create_adal_context(self):
Step #2:         authority_url = self.cloud_environment.endpoints.active_directory
Step #2:         is_adfs = bool(re.match('.+(/adfs|/adfs/)$', authority_url, re.I))
Step #2:         if is_adfs:
Step #2:             authority_url = authority_url.rstrip('/')  # workaround: ADAL is known to reject auth urls with trailing /
Step #2:         else:
Step #2: >           authority_url = authority_url + '/' + self._tenant
Step #2: E           TypeError: can only concatenate str (not "NoneType") to str
Step #2:
Step #2: /usr/local/lib/python3.7/site-packages/msrestazure/azure_active_directory.py:109: TypeError

What did you expect to happen:

Anything else you would like to add: [Miscellaneous information that will assist in solving the issue.]

Environment:

• Fairing version: (use python -c "import fairing; print(fairing.__version__)"):
• Kubeflow version: (version number can be found at the bottom left corner of the Kubeflow dashboard):
• Minikube version:
• Kubernetes version: (use kubectl version):
• OS (e.g. from /etc/os-release):

NOTE: If you are using fair from master, please provide us the git commit hash.

[issue-label-bot[bot]]

Issue-Label Bot is automatically applying the label kind/bug to this issue, with a confidence of 1.00. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

[jinchihe]

@vjrantal Seems need to be update to below?

        client_id=os.environ.get('AZ_CLIENT_ID', ''),
        secret=os.environ.get('AZ_CLIENT_SECRET', ''),
        tenant=os.environ.get('AZ_TENANT_ID', '')

[vjrantal]

@jinchihe It is true that the Azure integration tests do not currently pass in the Google CI environment, but the workaround was to ignore them there (see this line).

If they currently cause problems or fail in some CI environment, my recommendation is to remove the folder tests/integration/azure until there is a better solution for multi-cloud CI.

[jinchihe]

@vjrantal Oh, got that, thanks for points out. I think that's better to have a plan to enable that, maybe just enable that by unit test, such as unittest.mock? otherwise, we may break the feature but we do not know that.

[jtfogarty]

/area engprod /priority p2