website icon indicating copy to clipboard operation
website copied to clipboard

Change twitter icon to X icon

Open pabitra0011 opened this issue 2 years ago • 5 comments

  • Please check if the PR fulfills these requirements
  • [x] The commit message follows our guidelines
  • [x] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

solved #444

Change twitter old icon to new X icon.

pabitra0011 avatar Nov 05 '23 21:11 pabitra0011

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign shelley-baoyue after the PR has been reviewed. You can assign the PR to them by writing /assign @shelley-baoyue in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kubeedge-bot avatar Nov 05 '23 21:11 kubeedge-bot

Welcome @pabitra0011! It looks like this is your first PR to kubeedge/website 🎉

kubeedge-bot avatar Nov 05 '23 21:11 kubeedge-bot

Could you please adjust the size of the twitter logo to the same with the surrounding logos?

image

Shelley-BaoYue avatar Nov 06 '23 01:11 Shelley-BaoYue

@pabitra0011 Looks great! And not sure why the icon looks not that clear..

fisherxu avatar Nov 07 '23 08:11 fisherxu

Hi, @pabitra0011, Is this task still in progress? Please address the DCO error and it seems that some unrelated files, such as package-lock.json, have been mistakenly included in the PR.

Shelley-BaoYue avatar Dec 04 '23 02:12 Shelley-BaoYue

@pabitra0011: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kubeedge-bot avatar May 27 '24 07:05 kubeedge-bot

https://github.com/kubeedge/website/pull/543 has completed it
/close

Shelley-BaoYue avatar May 27 '24 08:05 Shelley-BaoYue

@Shelley-BaoYue: Closed this PR.

In response to this:

https://github.com/kubeedge/website/pull/543 has completed it
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kubeedge-bot avatar May 27 '24 08:05 kubeedge-bot