ktprograms

Results 110 comments of ktprograms

@skjnldsv Can you please take a look at my replies (in particular the one about the hover background) Also I'm assuming the `Node / node` test failed because I didn't...

>Which issue does this PR close? Please link it. Thanks! :) I don't think there are any

> Thanks for the answer! So it doesn't fix #916? No, the mobile drag/zoom APIs are quite different.

> The PRs title sounded like it could have fixed the mentioned issue. What the `scroll to zoom` meant is that previously, whenever I scroll on an image it just...

@skjnldsv I think I've done all the changes you requested in https://github.com/nextcloud/viewer/pull/1063/commits/aa829e43a0ed62d69a0df95799b7ca53165d2c87

@skjnldsv https://github.com/nextcloud/viewer/pull/1063/commits/70957b6cbbea5e3c524a997e3bbcbb9f5c7991e7 is because I set up `YouCompleteMe`, so I also fixed a few `vls` diagnostic warnings (all in the doc comments). If you don't want the `jsconfig.json` file or...

Should I squash the handling of transparent images together with the fix zoom commit? Also, _why_ are the built js files stored in the repo? It makes it so much...

@skjnldsv The way to fix both the title and arrows being over the image is to put the image in a smaller box that's not overlapping with the title and...

@skjnldsv Sorry, I don't get why a warning would need to be shown?

Also should I do the fix I suggested and put the image in a smaller box?