kshaffer
images and PHP 7.2 compatibility
Kris:
I was running your plugin on a server with PHP 7.2.2 and I noted some errors based on new things in PHP that pertain to an area of the code that I'm not sure works anyways, in lines 91-110 of https://github.com/kshaffer/hypothesis_aggregator/blob/master/hypothesis-aggregator.php, commented as: // grab post image from open graph or Twitter, if available
I'm not clear that any images are available to display and there are issues with PHP being confused about what's an object and what's an array in this part of the code, which throws errors in 7.2.2. Also I don't think the $image_url ever gets set with any value, which generates errors too.
I don't know enough about the inner workings to know if there are images somewhere to get, or if this was optimistic code that should maybe be shelved until such a time as Hypothesis is providing images?
