Krsto Proroković
Krsto Proroković
> Btw, @krstopro, would you like to join the Scholar team alongside @msluszniak? No additional commitment is required from your side, it is mostly to recognize your contributions so far....
@tiagodavi I already started working on this one, but still a way to go. If you really insist you can go for it.
Given that each of these modules contains `fit_transform/2`, I think it is safe to deprecate/remove `Scholar.Preprocessing`. Only `Binarizer` module remains to be implemented. Just my opinion, curious to see what...
> Hey @krstopro , This looks really good. Also from what I remember, including `mahalanobis_distance` into aeon was still under discussion so I would recommend putting this on the slack...
> @krstopro Also, you rightly said that they've implemented the "squared" mahalanobis distance. In aeon, I think we should discuss it once if we want to implement the squared or...
> @chrisholder @aadya940 @krstopro Just checking in, everything good with this PR? Feel free to ask questions if you need some help. @MatthewMiddlehurst Yes, sorry. I was just busy and...
@MatthewMiddlehurst Not yet, sorry. I hope to push by the end of the week. Apologies for the delay.
Hi @ksew1 and thanks for the pull request! Looks great on the first look and I will be having a detailed review soon.
Any reason why `num_categories` isn't a required option?
@josevalim @msluszniak I am still having a look. Seems very good, but please give me some time before merging. I might have some improvements to suggest (e.g. maybe the code...