stdweb icon indicating copy to clipboard operation
stdweb copied to clipboard

Road to `0.5.0`

Open koute opened this issue 7 years ago • 7 comments

[ ] - (breaking change) Switch to upstream TryInto/TryFrom. (This will require removing some blanket impl (e.g. for TryFrom< Value > for Option< T >) and some concrete impls (e.g. From< Array > for Vec< Value > needs to be removed due to Rust's coherence rules); it will also require converting some TryFrom impls into TryInto impls (again - due to coherence rules) and modifying some trait bounds (e.g. in JsSerialize impl for closures from TryFrom into TryInto)) [ ] - (possibly breaking change?) Move webcore into a separate crate. [ ] - (breaking change) IPointerEvent::{pressure, tangential_pressure} should return f32. [ ] - (breaking change) Add MouseButton::Eraser variant. (Rename it to Button6 maybe?) [ ] - (breaking change) Wrap subscription-like types with autodrop wrapper (EventListenerHandle, etc.) [ ] - (should be non-breaking but might be) Switch from a WeakMap to a Map? [ ] - Add support for converting to/from f32. [ ] - (breaking change) Get rid of get_ prefixes from the getters.

(... possibly more ...)

koute avatar Apr 01 '18 23:04 koute

Please consider dropping the "stable ID" guarantee for 0.5.0 - we can provide an explicit "stable ID" api for users who need it, and it will remove the core dependency on WeakMap.

Diggsey avatar Apr 03 '18 22:04 Diggsey

The following APIs are not actually web APIs, they are instead JavaScript APIs:

  • stdweb::web::Date
  • stdweb::web::TypedArray
  • stdweb::web::ArrayBuffer
  • stdweb::web::error::IError
  • stdweb::web::error::Error
  • stdweb::web::error::TypeError

Therefore they should be moved into core.

I believe the above list is thorough, but I might have missed a couple APIs.

Pauan avatar Apr 09 '18 11:04 Pauan

@Pauan I think you can add SecurityError to that list.

vitiral avatar Apr 11 '18 23:04 vitiral

@vitiral But SecurityError is a DOM error, right? Am I missing something?

Pauan avatar Apr 12 '18 00:04 Pauan

Bump -- any ETA on this at all? Especially the first one; it's mildly annoying to keep around extra copies of the same trait, now that it's been standardized.

nic-hartley avatar Jul 30 '19 21:07 nic-hartley

@nic-hartley I have this work started on a private branch, but it's currently on the backburner.

koute avatar Aug 01 '19 20:08 koute

@koute Anything you'd like help with? I've been using stdweb (and cargo web) lately; I'm happy to contribute back.

nic-hartley avatar Aug 01 '19 23:08 nic-hartley