SingleSignOnServiceProviderBundle icon indicating copy to clipboard operation
SingleSignOnServiceProviderBundle copied to clipboard

add support for symfony 4

Open Evgen14 opened this issue 7 years ago • 4 comments

Evgen14 avatar Sep 30 '18 13:09 Evgen14

Hi, would you be able to add such a support?

korotovsky avatar Sep 30 '18 13:09 korotovsky

in my project works, if replace symfony/symfony:~2.8|~3.0 on symfony/framework-bundle:~2.8|~3.0|~ 4.0 in

  • SingleSignOnLibrary
  • SingleSignOnIdentityProviderBundle
  • SingleSignOnServiceProviderBundle

but unfortunately, there is no way to completely test

Evgen14 avatar Sep 30 '18 15:09 Evgen14

Could you provide a PR?

korotovsky avatar Oct 01 '18 20:10 korotovsky

I made a pull request to the SingleSignOnLibrary, then I can do it in the rest of the bundles

Evgen14 avatar Oct 02 '18 07:10 Evgen14