kong-client-ruby icon indicating copy to clipboard operation
kong-client-ruby copied to clipboard

Kong1dot1

Open mtmail opened this issue 6 years ago • 16 comments

Splits /apis endpoint into /routes and /services that Kong 1.0 introduced. We're running this fine for 6 months now. First Kong 1.1, currently Kong 1.4

mtmail avatar Nov 12 '19 16:11 mtmail

I split off the Travis and rubocop fixes into separate PRs.

mtmail avatar Nov 20 '19 17:11 mtmail

@mtmail @nevalla This is a very useful PR. Is there anything blocking this?

irfn avatar Dec 11 '19 09:12 irfn

@mtmail if you are using this rt now, is there a gem version published somewhere?

irfn avatar Dec 11 '19 10:12 irfn

@mtmail i was not able to add upstreams for using this and getting Kong::Error ({"message":"schema violation (upstream_id: unknown field)","name":"schema violation","fields":{"upstream_id":"unknown field"},"code":2})

the docs show target structure has changed https://docs.konghq.com/1.4.x/admin-api/#add-target

irfn avatar Dec 12 '19 10:12 irfn

@mtmail

This is a workaround i am doing to make this work https://github.com/irfn/kong-client-ruby/commit/a0ee5914d96f5894a03024b5a4356d7fe3101f46 hope you can address this.

irfn avatar Dec 12 '19 11:12 irfn

Actually ignore the above workaround. It only allows you to create and not view. Here i have updated this to handle update & view (still workaround quality)

https://github.com/irfn/kong-client-ruby/commit/758974e464665695c5214da4760fd9c1e05384ac

irfn avatar Dec 12 '19 11:12 irfn

@mtmail @irfn sometimes it seems like this gem is not being maintained anymore, but I'm not sure. Did you publish your fork publicly in the Rubygems?

Do you intend to maintain a fork to let it updated with new Kong versions? I'm interested to help.

arthurmde avatar Dec 17 '19 13:12 arthurmde

Hi, sorry for not giving any feedback here. Finally, I have now time to push this further. So, I'll test this out with the latest version of Kong and review the PR.

After we get this merged I'll create a beta/rc build so you can test it too.

nevalla avatar Dec 17 '19 13:12 nevalla

Please could you rebase and resolve conflicts. Meta PRs are now merged so it would be easier to review this PR.

nevalla avatar Dec 17 '19 14:12 nevalla

I split off the bundler,rake changes into a separate PR https://github.com/kontena/kong-client-ruby/pull/42

mtmail avatar Dec 17 '19 14:12 mtmail

@mtmail do you intend to work on Kong 1.4.x support? I mentioned the issue in the thread.

irfn avatar Dec 17 '19 15:12 irfn

@irfn I'm using this library with 1.4.0 already, I guess not the feature you mention. Can you create a separate github issue?

mtmail avatar Dec 17 '19 16:12 mtmail

Rebased, squashed, and tests passing. I set version to 0.4.0 and added a changelog entry.

mtmail avatar Dec 17 '19 16:12 mtmail

@irfn I'm using this library with 1.4.0 already, I guess not the feature you mention. Can you create a separate github issue?

Ill retest and raise issue once this is merged. thanks!

irfn avatar Dec 19 '19 06:12 irfn

Any update?

We are really looking forward to use Kong::Service and working Kong::JWT :)

YusukeIwaki avatar Dec 11 '20 07:12 YusukeIwaki

My fork works with Kong 2.x

mtmail avatar Dec 11 '20 11:12 mtmail