stdBLAS icon indicating copy to clipboard operation
stdBLAS copied to clipboard

Implement scaled_accessor LWG review changes (& analogous conjugate_accessor changes)

Open mhoemmen opened this issue 2 years ago • 0 comments

  • Rename accessor_scaled to scaled_accessor
  • Change scaled_accessor::reference to the actual product value, and change element_type accordingly
  • Add full converting constructor (scaling factor and/or input scaled_accessor's nested accessor could differ)
  • Make scaled_accessor::access conditionally (instead of unconditionally) noexcept
  • Rename accessor_conjugate to conjugate_accessor
  • Implement analogous changes to conjugate_accessor
  • Fix implementation of conj-if-needed, and add implementations (and tests) of real-if-needed and imag-if-needed
  • Add tests mixing result of scaled with an mdspan whose accessor uses a proxy reference as its reference type. This increases confidence that the new (proxy-reference-free) design works.

mhoemmen avatar Jul 26 '23 04:07 mhoemmen