boilerpipe icon indicating copy to clipboard operation
boilerpipe copied to clipboard

Please remove nekohtml classes from your project

Open unoexperto opened this issue 8 years ago • 5 comments

Could you please remove nekohtml classes from your project ? Those should be referenced through dependency, not included into your jar directly. It causes problems when someone tries to build monolithic jar of his project.

Thanks.

unoexperto avatar Jun 17 '17 10:06 unoexperto

It causes much more problems, like incompatibilities with actual neko html on the class path but in different versions and then depending on class path ordering things happen to work or fail and so on.

Vampire avatar Jul 27 '22 14:07 Vampire

Please provide an example how a relocated package interferes with the actual nekohtml. I see that this bug has been open for a while without other comments, perhaps it's not a widespread problem?

Ideally, please provide a patch to fix it the way how you see it work best. This way, we can narrow down the issue, even if the actual fix that gets mainlined may differ.

The reason why we packaged nekohtml with boilerpipe was that there were upstream bugs in nekohtml that needed fixing, and there was a chance that these fixes would either be overridden by someone's nekohtml version on the classpath, or cause other problems down the road in other apps on the classpath.

kohlschuetter avatar Jul 27 '22 15:07 kohlschuetter

The problem is, that the classes are not relocated, just repackaged into your jar, at least in case of the one on Maven Central. If you would have relocated them, there would be less a problem.

Why you don't get more complaints I can only guess. Possible reasons:

  • often people don't complain, but just are annoyed or stop using the library
  • if they want to complain, they might see the already open issue and don't add anything (thumbs-upping is also not obvious to be used as up-voting)
  • if they do not combine with another Neko version, there is no problem
  • even if they combine with another Neko version it depends on class path order whether there are problems
  • ...

Vampire avatar Jul 27 '22 20:07 Vampire

Thanks for your comment. I wasn't able to touch this library for a while but I may look into that at some point. However, like with many open source projects run by individuals, it's a matter of prioritization. In the meantime, please see if your problem persists with the code from this repository's main branch and, ideally, provide a pull request. This will speed up things.

kohlschuetter avatar Jul 27 '22 20:07 kohlschuetter

Frankly I don't even remember if I used boilerpipe back then :) Judging by the description of the library I think ended up using jsoup.

unoexperto avatar Jul 28 '22 09:07 unoexperto