graphql-java-codegen icon indicating copy to clipboard operation
graphql-java-codegen copied to clipboard

Change default value of generateParameterizedFieldsResolvers to false

Open kobylynskyi opened this issue 4 years ago • 2 comments

Changes should be done in:

  • [ ] Core library + unit tests
  • [ ] Gradle plugin
  • [ ] Maven plugin
  • [ ] SBT plugin
  • [ ] Migration guide: 5.x.x -> 6.0.0

Related to #676 #476 #221 #1383

kobylynskyi avatar Apr 30 '21 16:04 kobylynskyi

Why should the default be false? That would make it more tedious to create parametrized fields, because you’d need to explicitly list them all out manually in the generateFieldResolvers config. I think it should stay true by default but only apply to non-@external parametrized fields.

gzak avatar Nov 10 '23 05:11 gzak

Also, out of curiosity - if generateParameterizedFieldsResolvers is false but you do have some parameterized fields in the schema, how are they supposed to be handled? Do you still get a resolver method somewhere, or are the inputs simply ignored?

gzak avatar Nov 11 '23 20:11 gzak