mount

mount copied to clipboard

Bumps [eslint](https://github.com/eslint/eslint) from 7.32.0 to 8.32.0. Release notes Sourced from eslint's releases. v8.32.0 Features fc20f24 feat: add suggestions for redundant wrapping in prefer-regex-literals (#16658) (YeonJuan) Bug Fixes b4f8329 fix: ignore...

dependabot[bot]

Bumps [mocha](https://github.com/mochajs/mocha) from 9.2.2 to 10.2.0. Release notes Sourced from mocha's releases. v10.2.0 10.2.0 / 2022-12-11 :tada: Enhancements #4945: API: add possibility to decorate ESM name before import (@​j0tunn) :bug:...

dependabot[bot]

Bumps [eslint-plugin-promise](https://github.com/eslint-community/eslint-plugin-promise) from 3.8.0 to 6.1.1. Release notes Sourced from eslint-plugin-promise's releases. v6.1.1 6.1.1 (2022-10-19) Bug Fixes no-multiple-resolved: false positives when the last expression in a try block is a...

dependabot[bot]

Restore path also when downstream throws

1

If the path is not restored on throw, then the upstream middlewares work with a wrong path. This will make metrics and logging etc. to show a wrong path for...

petuomin

Bumps [eslint-config-standard](https://github.com/standard/eslint-config-standard) from 7.1.0 to 16.0.3. Commits 2cfcbfd 16.0.3 8fdbb45 fix: allow eslint-plugin-promise v5 as peer dependency (#186) 8c5203f 16.0.2 25a0d26 Relax rule: Enforce default parameters to be last (default-param-last)...

dependabot[bot]

Custom error thrown inside mounted app is converted to native Error

2

It's fairly common to throw objects inherited from Error, such as this: ``` class HttpError extends Error { constructor(public status: number, message?: string) { super(message); this.name = 'HttpError'; Error.captureStackTrace(this, HttpError)...

DreadBoy

DreadBoy

it causes more problems than it solves and is a smell.

jonathanong

mounted app.context doesn't get applied to parent app

4

Example: ``` const mount = require('koa-mount'); const Koa = require('koa'); const a = new Koa(); a.context.test = "hallo"; a.use(async function (ctx, next){ ctx.body = "test:" + ctx.test; return next(); });...

Nostradamos

use path-to-regex for express-like mounted routes

8

``` js app.use(mount('/:id(\d+)', fn)) ``` interested? path-to-regex does prefix routing. should be backwards compatible. not sure how i want to handle keys though. maybe `(next, keys...)`

jonathanong