scribe icon indicating copy to clipboard operation
scribe copied to clipboard
verified publisher icon knuckleswtf

Feature:document generation support i18n

Open fplun opened this issue 3 years ago • 1 comments

Add configuration item:language

Support multi language conversion to ASCII when generating documents

fplun avatar Dec 05 '22 08:12 fplun

Thanks for the PR. I'm a bit dissatisfied, though.

  1. The config file param language does not explain what it's for. This is misleading because of point (2):
  2. This isn't full internationalization. Which is okay, but I'd rather release internationalization as a complete feature. Having language in there when it's only used for generating slugs would definitely be confusing. Perhaps I'll create a branch for that.
  3. Also, it looks like your usage of Str::slug is incorrect? language is the third parameter: https://github.com/illuminate/support/blob/475bda9d24e832388d5514683bec5ea6ef9a3c94/Str.php#L1016

I think it's a good start, though.

shalvah avatar Dec 13 '22 19:12 shalvah

My English is poor，I'm looking forward to it. I hope this project will be better and better

fplun avatar Dec 15 '22 03:12 fplun