language-bash

language-bash copied to clipboard

Annotate AST with comments and source positions

11

It would be useful for me if comments were put in the AST in a "Comment" construct (I plan to translate them into Comments in my new language).

pbiggar

Performance

3

I use language-bash in ghcup to parse variable assignments from files like `/etc/os-release`: https://gitlab.haskell.org/haskell/ghcup-hs/-/blob/master/lib/GHCup/Utils/Bash.hs This works relatively well, but when I profile ghcup on the simplest command `ghcup list`, I...

hasufell

Switch from Parsec to Megaparsec

4

Megaparsec is more actively maintained, and will give us better error messages

knrafto

Expose ByteString version of 'parse'

2

https://hackage.haskell.org/package/language-bash-0.9.0/docs/Language-Bash-Parse.html#v:parse is only String. That is really unfortunate. String is both a weird (not even UTF-8) format and is unefficient. I generally don't use it at all. Nothing else from...

hasufell

I tried to get all top-level assignments and ended up with: ```hs extractAssignments :: List -> [Assign] extractAssignments (List stms) = join $ fmap getAssign $ getCommands stms where getCommands...

hasufell

Brace expansion edge case

5

QuickCheck found this in [this job](https://travis-ci.org/knrafto/language-bash/jobs/162677842) ``` Tests Properties brace expansion: FAIL (0.08s) *** Failed! Assertion failed (after 56 tests): "\\}\\,,{y}{\\{\\ }\\}{}\\}s\\ p\\{\\},\\,lhhiq\\,qv}{}\\},}\\}\\ \\,{\\}\\ \\{a\\ \\,\\,z\\,t" Use --quickcheck-replay '55 TFGenR...

knrafto

e.g. ``` echo 'foo' | cat ``` Right now we can't handle a newline after `|`.

knrafto

It would be nice if we had `Monoid` and `Semigroup` instances for the `List` type.

mmhat

Pretty printing of here documents without trailing newline

6

Consider the following here document: Heredoc Here "EOF" False (stringToWord "here document") If pretty printed it looks like that:

mmhat

Arithmetic is not parsed

2

Looks like arithmetic becomes an `ArithSubst String`, and it isn't parsed any further. What's the plan there? Should I instead try to parse the arithmetic strings as C?

pbiggar