website icon indicating copy to clipboard operation
website copied to clipboard

Add borders to tables

Open samodell opened this issue 6 years ago • 4 comments

Content in tables is easier to read when there are borders.

For an example of a table in our docs, see: https://www.knative.dev/docs/serving/samples/

On GitHub, the table displays with a simple border that makes it more readable: https://github.com/knative/docs/tree/master/docs/serving/samples

samodell avatar Mar 22 '19 18:03 samodell

Hm, @RichieEscarez , it looks like there are now horizontal borders for rows in tables, but columns still don't have a border. A simple 1px border on all sides is what I was hoping for, to mimic the way GitHub renders tables.

samodell avatar Apr 19 '19 18:04 samodell

We need to override the default Docsy CSS. We can circle back around when things start to cool down a bit.

RichieEscarez avatar Apr 19 '19 19:04 RichieEscarez

Yeah, totally not high priority.

samodell avatar Apr 19 '19 19:04 samodell

Another option would be to request that update to the template (sounds like it would be beneficial to all)? https://github.com/google/docsy/issues

RichieEscarez avatar Apr 19 '19 19:04 RichieEscarez