Check all container's status when calculating revision ContainerHealthy condition

[seongpyoHong]

Fixes #14567

Release Note

Check all container's status when calculating revision ContainerHealthy condition

[knative-prow[bot]]

Hi @seongpyoHong. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 80.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 84.13%. Comparing base (88abc84) to head (9bc98bf). Report is 28 commits behind head on main.

Files	Patch %	Lines
pkg/reconciler/revision/reconcile_resources.go	75.00%	1 Missing :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #14744      +/-   ##
==========================================
+ Coverage   84.08%   84.13%   +0.05%     
==========================================
  Files         213      213              
  Lines       16687    16687              
==========================================
+ Hits        14031    14040       +9     
+ Misses       2303     2299       -4     
+ Partials      353      348       -5     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[dprotaso]

/hold

I want to fix https://github.com/knative/serving/issues/14660 prior

[dprotaso]

Still holding for now see: https://github.com/knative/serving/issues/14567#issuecomment-1949639591

A serving point release came out two weeks ago - that might have fixed the original issue.

[dprotaso]

Still holding for now see: #14567 (comment)

A serving point release came out two weeks ago - that might have fixed the original issue.

The other fix didn't address the issue this PR addresses

/hold cancel

[dprotaso]

/ok-to-test

[seongpyoHong]

@dprotaso Sorry for the late reply.

I've fixed and rebased it to reflect your feedback.

[dprotaso]

@seongpyoHong thanks for the changes

/lgtm /approve

Are you able to follow up by adding a unit test or an e2e test?

[knative-prow[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, seongpyoHong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [dprotaso]
• ~~pkg/apis/OWNERS~~ [dprotaso]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[seongpyoHong]

Are you able to follow up by adding a unit test or an e2e test?

Sure, I will also add the unit test and e2e test.