serving icon indicating copy to clipboard operation
serving copied to clipboard

Support Wildcard ClusterDomainClaims

Open arsenetar opened this issue 2 years ago • 4 comments

Describe the feature

To support easier management in environments where auto-creating ClusterDomainClaims is not desired, support wildcard ClusterDomainClaims. This would allow a domain claim such as:

apiVersion: networking.internal.knative.dev/v1alpha1
kind: ClusterDomainClaim
metadata:
  name: *.test.com
spec:
  namespace: test

To allow any subdomain usage of test.com within the test namespace in domainmappings.

arsenetar avatar Nov 30 '23 18:11 arsenetar

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

github-actions[bot] avatar Feb 29 '24 01:02 github-actions[bot]

/remove-lifecycle stale

braunsonm avatar Feb 29 '24 01:02 braunsonm

From: https://github.com/knative/serving/pull/14881#issuecomment-2021492474

Yeah the way this feature was implemented it uses name conflicts in the cluster scope to ensure there are no duplicates.

If we wanted to support wild cards then we'd have to modify the existing ClusterDomainClaim resource and introduce controllers to try to ensure the same guarantee.

If this is something you're interested in pursuing then we'd probably want to write up a feature track document.

dprotaso avatar Mar 26 '24 21:03 dprotaso

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

github-actions[bot] avatar Jun 25 '24 01:06 github-actions[bot]