pkg icon indicating copy to clipboard operation
pkg copied to clipboard

Migrate from OpenCensus to OpenTelemetry

Open anniefu opened this issue 6 years ago • 10 comments

OpenCensus & OpenTracing have merged to form OpenTelemetry (see https://github.com/census-instrumentation/opencensus-go & https://medium.com/opentracing/a-roadmap-to-convergence-b074e5815289).

Knative should to move to instrumenting metrics and traces with OpenTelemetry instead of OpenCensus ahead of OpenCensus getting deprecated.

anniefu avatar Nov 07 '19 19:11 anniefu

Looks like OpenTelemetry Go SDK is in beta now: https://github.com/open-telemetry/opentelemetry-go

grantr avatar May 11 '20 20:05 grantr

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

github-actions[bot] avatar Aug 24 '20 16:08 github-actions[bot]

/lifecycle frozen /assign @evankanderson @jjzeng-seattle

vagababov avatar Aug 24 '20 17:08 vagababov

I have done an evaluation on this topic here are the takeaways. From my POV otel is not ready yet, I would wait for GA. There is also a spike for this in wip status. We discussed this on a community meeting as well.

skonto avatar Feb 17 '21 16:02 skonto

/unassign

evankanderson avatar May 25 '21 14:05 evankanderson

/unassign @jjzeng-seattle

evankanderson avatar May 25 '21 14:05 evankanderson

FYI - there's a bridge for OpenCensus => OpenTelemetry

So we can use the OTel exporters and slowly transition the API usage over

https://github.com/open-telemetry/opentelemetry-go/tree/main/bridge/opencensus#user-journey

I think tracing would be the best POC to test this out with

dprotaso avatar Jul 26 '22 18:07 dprotaso

FYI - Bug in metrics/otelhttp handler causes high cardinality https://github.com/open-telemetry/opentelemetry-go-contrib/issues/3765 - fixed in https://github.com/open-telemetry/opentelemetry-go-contrib/pull/4277

dprotaso avatar May 24 '23 12:05 dprotaso

When performing the migration we should consider how we name the service -

The suggestion here is that hostname is not a good one because it changes as pods come up and down - https://github.com/knative/serving/pull/14075

dprotaso avatar Sep 12 '23 00:09 dprotaso

Otel go sdk i snow stable wrt metrics. See https://github.com/knative/serving/issues/14486 for pointers. We should define a plan on how to work on this one.

skonto avatar Oct 06 '23 14:10 skonto