knative
Updating Activator's `terminationGracePeriodSeconds` value
Hello everyone.
I am also interested in setting max-revision-timeout-seconds to a larger value. However I can't find how to update the terminationGracePeriod in activator.
From @mkyrilov 's comment in Serving:
I am using the operator to install Knative Serving:
apiVersion: operator.knative.dev/v1beta1
kind: KnativeServing
metadata:
name: knative-serving
namespace: knative-serving
spec:
version: 1.8.0 # Same version as the operator
config:
defaults:
max-revision-timeout-seconds: "7200" # 120 minutes
domain:
kn.example.com: "" # your DNS
features:
kubernetes.podspec-persistent-volume-claim: "enabled"
kubernetes.podspec-persistent-volume-write: "enabled"
kubernetes.podspec-affinity: "enabled"
kubernetes.podspec-tolerations: "enabled"
kubernetes.podspec-init-containers: "enabled"
istio:
gateway.knative-serving.knative-ingress-gateway: istio-ingressgateway.istio-ingress.svc.cluster.local
Does anyone know how to achieve this?
I did try editing the activator deployment manually. It updates fine, but then immediately gets reverted back. I am assuming the operator does this.
This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.
This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.
This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.
This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.
This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.
@psschwei did you find a solution?
I tried increasing max-revision-timeout-seconds, but when trying long requests I'm getting this error: activator request timeout
I believe I could soulve that by increasing the Activator's terminationGracePeriodSeconds value
@CarlosDomingues this wasn't my issue, I was just moving @mkyrilov 's comments into this repo
cc @houshengbo
This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.
This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.
So far, knative operator does not support the configuration of terminationGracePeriodSeconds in all deployment resources. It reverts to the default value 600, even if you manually change it.
Downstream we use extension logic to set this. I think I can bring it upstream to be part of the core logic, I am not sure if we really need overrides for the terminationGracePeriodSeconds for all deployments.
It makes sense for the data plane component (activator) especially when the default value for max-revision-timeout-seconds changes. @houshengbo wdyth?
So if that's the case, then is it accurate to say that, when using the knative serving operator, we will not be able to have requests that run longer than 600 seconds no matter what we set the various timeouts to?
This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.