allow digested images to be 'run'
In order to match the deploy command, make it possible to run digested images as well when building into the container
todo:
- [x] integration tests? - make sure correct digested image is used
- [x] digested image deploys correct image (
.Build.Image) when--container=true - [ ] undigested images direct deploy only with
--build=falseflag
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
Codecov Report
Attention: Patch coverage is 68.96552% with 18 lines in your changes missing coverage. Please review.
Project coverage is 66.73%. Comparing base (
4775ad9) to head (4c3bbb4). Report is 3 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #2445 +/- ##
==========================================
+ Coverage 61.22% 66.73% +5.51%
==========================================
Files 130 130
Lines 15354 11950 -3404
==========================================
- Hits 9400 7975 -1425
+ Misses 5029 3012 -2017
- Partials 925 963 +38
| Flag | Coverage Δ | |
|---|---|---|
| e2e-test | 36.67% <24.13%> (-0.11%) |
:arrow_down: |
| e2e-test-oncluster | 33.28% <18.96%> (-0.03%) |
:arrow_down: |
| e2e-test-oncluster-runtime | 29.38% <5.17%> (?) |
|
| e2e-test-runtime-go | 26.67% <18.96%> (?) |
|
| e2e-test-runtime-node | 26.06% <18.96%> (?) |
|
| e2e-test-runtime-python | 26.06% <18.96%> (?) |
|
| e2e-test-runtime-quarkus | 26.16% <18.96%> (?) |
|
| e2e-test-runtime-rust | 25.17% <18.96%> (?) |
|
| e2e-test-runtime-springboot | 25.24% <18.96%> (?) |
|
| e2e-test-runtime-typescript | 26.15% <18.96%> (?) |
|
| integration-tests | 52.78% <68.96%> (+2.37%) |
:arrow_up: |
| unit-tests | 50.97% <68.96%> (?) |
|
| unit-tests-macos-latest | ? |
|
| unit-tests-ubuntu-latest | ? |
|
| unit-tests-windows-latest | ? |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: gauron99 / name: David Fridrich (0dfb1782bffe6c8f238d60bdeb3852da501483e7, 6d8b1fe2508b0ef027d2481b2049a62e04b73c44, 82f7459fb5008888c2ceca507d071eee12029370, 21e1b5603fbc40525ac2c57ef99e92c4f5dbdbe4, eba5c03d66932bf45cb39978ae31a632547206ed, 0ddc30a1c14578906aa1f85d5f5baab3ec5e40a9, 34f237e367edab44360f71636504803a532fe92d, a5617d408faf303f40eed62f834a9be38388262e, 298f71b633b56b7a33a88f46c72c8d71a6b58cff, a0a00e3ba9951c9b20f581350dbdb49e7e051ef0, 25dba57fb091a4b4456a330daada4fa6a0f0ea99, 9d20af79a89d3199b8454fdf84acb3f16cba0177, 4c3bbb4d3b98d9b3abffb0498628c2c556d3ace1, d094e349c41ab031d295464a08b92bc4b25e3b39, d095a39f125e4fdbc0499b12b125a2e45e19ab63, ea396393912f831306822ee24614c3e78a7e3f2b)
/approve
Looking good
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: gauron99, lkingland
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [gauron99,lkingland]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/unhold