eventing icon indicating copy to clipboard operation
eventing copied to clipboard

add mqtt source

Open Rahul-Kumar-prog opened this issue 1 year ago • 4 comments

Fixes #7207

Proposed Changes

  • implement a mqtt protocol source which can transforming messages from MQTT brokers to Cloudevents

Pre-review Checklist

  • [ ] At least 80% unit test coverage
  • [ ] E2E tests for any new behavior
  • [ ] Docs PR for any user-facing impact
  • [ ] Spec PR for any new API feature
  • [ ] Conformance test for any change to the spec

Release Note


Docs

Rahul-Kumar-prog avatar Mar 21 '24 08:03 Rahul-Kumar-prog

Hi @Rahul-Kumar-prog. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

knative-prow[bot] avatar Mar 21 '24 08:03 knative-prow[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Rahul-Kumar-prog Once this PR has been reviewed and has the lgtm label, please assign lionelvillard for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

knative-prow[bot] avatar Mar 21 '24 08:03 knative-prow[bot]

@Leo6Leo can you have a look on this PR.

Rahul-Kumar-prog avatar Mar 21 '24 08:03 Rahul-Kumar-prog

Raul, thanks for the PR, I will take a look - but I am not atm if this repo is the best option. But yeah, there is already a websocket sample source in here as well

matzew avatar Mar 25 '24 06:03 matzew

@Rahul-Kumar-prog Hello Rahul, any reason why you are closing the PR?

Leo6Leo avatar May 06 '24 14:05 Leo6Leo

@Leo6Leo i have an idea so I closed the draft pr. And going to create a new one with optimise solution that's why. And need some help I will dm you on slack.

Rahul-Kumar-prog avatar May 06 '24 17:05 Rahul-Kumar-prog

Ohh so this issue taken with someone so @Leo6Leo can you point me any issue I can work on there is no more good first issue.

Rahul-Kumar-prog avatar May 06 '24 17:05 Rahul-Kumar-prog

@Rahul-Kumar-prog If you have a more optimized solution, feel free to share it here in public and have the discussion with the community

Leo6Leo avatar May 06 '24 19:05 Leo6Leo

@Rahul-Kumar-prog Regarding the new good-first-issue, I would suggest you use CLOtributor to seek for the good-first-issue. https://clotributor.dev/search?ts_query_web=knative&page=1

Leo6Leo avatar May 06 '24 19:05 Leo6Leo

thankyou so much @Leo6Leo

Rahul-Kumar-prog avatar May 06 '24 20:05 Rahul-Kumar-prog