[WIP] Add retries to test event senders to mitigate networking errors

[pierDipi]

A common and recurring error I've seen in failed E2E tests is Connection reset by peer.

This patch adds retries to test event senders so that we mitigate networking errors.

Proposed Changes

• Add retries to test event senders to mitigate networking errors

Pre-review Checklist

• [ ] At least 80% unit test coverage
• [ ] E2E tests for any new behavior
• [ ] Docs PR for any user-facing impact
• [ ] Spec PR for any new API feature
• [ ] Conformance test for any change to the spec

Release Note

None

Docs

None

[codecov[bot]]

Codecov Report

Merging #5976 (afe9f59) into main (ab80d13) will decrease coverage by 0.14%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5976      +/-   ##
==========================================
- Coverage   82.24%   82.09%   -0.15%     
==========================================
  Files         220      231      +11     
  Lines        7576     7765     +189     
==========================================
+ Hits         6231     6375     +144     
- Misses        911      940      +29     
- Partials      434      450      +16     

Impacted Files	Coverage Δ
pkg/reconciler/broker/config.go	76.47% <0.00%> (-10.20%)	:arrow_down:
pkg/broker/filter/filter_handler.go	72.44% <0.00%> (-8.60%)	:arrow_down:
pkg/eventfilter/attributes/filter.go	94.59% <0.00%> (-5.41%)	:arrow_down:
pkg/kncloudevents/message_sender.go	86.27% <0.00%> (-3.93%)	:arrow_down:
pkg/adapter/v2/cloudevents.go	80.80% <0.00%> (-2.71%)	:arrow_down:
pkg/apis/eventing/v1/trigger_types.go	100.00% <0.00%> (ø)
pkg/reconciler/pingsource/pingsource.go	80.95% <0.00%> (ø)
...reconciler/pingsource/resources/receive_adapter.go	100.00% <0.00%> (ø)
pkg/eventfilter/filter.go
pkg/eventfilter/subscriptionsapi/any_filter.go	100.00% <0.00%> (ø)
... and 16 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ab80d13...afe9f59. Read the comment docs.

[pierDipi]

I reviewed this ~1 month ago and forgot to submit. Sorry!

No worries, thanks!

I need to find out why there are failed tests :)

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: odacremolbap, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~test/OWNERS~~ [pierDipi]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[knative-prow-robot]

@pierDipi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-knative-eventing-conformance-tests	afe9f595da033c79d432f322dfaf77d4337e8e43	link	true	/test pull-knative-eventing-conformance-tests
pull-knative-eventing-reconciler-tests	afe9f595da033c79d432f322dfaf77d4337e8e43	link	true	/test pull-knative-eventing-reconciler-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[odacremolbap]

/retest

[knative-prow[bot]]

@pierDipi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
conformance-tests_eventing_main	afe9f595da033c79d432f322dfaf77d4337e8e43	link	true	/test conformance-tests_eventing_main

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[github-actions[bot]]

This Pull Request is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen with /reopen. Mark as fresh by adding the comment /remove-lifecycle stale.