eventing icon indicating copy to clipboard operation
eventing copied to clipboard

Improve EventType Registry

Open nachocano opened this issue 6 years ago • 12 comments

Problem EventType is tightly coupled with Broker. In fact, it has a broker attribute in its spec. We should decouple EventType from it. The EventType registry itself should be "autonomous", while other constructs (e.g., brokers, channels) should be able to refer to it (ack @markfisher ) This idea has been floating around for a while now, probably since the EventType registry inception (ack @n3wscott).

We should also probably add few more things to it, such as available extensions an EventType can produce, etc. Still TBD.

Creating this issue separately from https://github.com/knative/eventing/issues/2484, which mainly refers to improving the current implementation.

Persona: Which persona is this feature for? Developer

Exit Criteria A decoupled EventType registry, "queryable" from different constructs

Time Estimate (optional): infinite

Additional context (optional) https://github.com/knative/eventing/issues/2484 for some initial proposals there...

/cc @vaikas @mikehelmick @n3wscott @mattmoor @grantr @lionelvillard @markfisher , etc, etc...

nachocano avatar Mar 11 '20 18:03 nachocano

/cc @mikehelmick

mikehelmick avatar Mar 19 '20 19:03 mikehelmick

Here are some initial thoughts on how we can improve EventType before promoting it to v1 (or maybe v1beta2?): https://docs.google.com/document/d/1LtDPmithgr6Myj9eagIQ6IHQjsjAtzZlX3d0D4fw2A0/edit#

It'd be great to get feedback from folks: /cc @vaikas

nachocano avatar Jul 27 '20 18:07 nachocano

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

github-actions[bot] avatar Oct 26 '20 01:10 github-actions[bot]

/remove-lifecycle stale

antoineco avatar Oct 26 '20 07:10 antoineco

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

github-actions[bot] avatar Jan 25 '21 02:01 github-actions[bot]

/remove-lifecycle stale

antoineco avatar Jan 26 '21 22:01 antoineco

Is this still relevant? Can we close it? @vaikas @n3wscott

slinkydeveloper avatar Feb 11 '21 15:02 slinkydeveloper

@grantr is working on this.

n3wscott avatar Feb 12 '21 01:02 n3wscott

/assign @grantr

slinkydeveloper avatar Feb 12 '21 07:02 slinkydeveloper

@grantr are you taking over Nacho's proposal or planning on taking a different approach?

antoineco avatar Feb 12 '21 09:02 antoineco

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

github-actions[bot] avatar May 14 '21 01:05 github-actions[bot]

/triage accepted

pierDipi avatar Mar 09 '22 14:03 pierDipi

The reconciler should also not enforce a broker:

	b, err := r.getBroker(et)
	if err != nil {
		if apierrs.IsNotFound(err) {
			logging.FromContext(ctx).Errorw("Broker does not exist", zap.Error(err))
			et.Status.MarkBrokerDoesNotExist()

matzew avatar Feb 15 '23 13:02 matzew

This is the newest version of the doc:

  • https://docs.google.com/document/d/1WhhLSJJ7GWcyidK0_78MpgRzyfjW-fkeXfo6UTudqOc/edit?resourcekey=0-q31cg7nTwdLIYXYUQqkTuw

(after the other referenced got copied over to new GDrive)

matzew avatar Apr 14 '23 11:04 matzew

/close we can close this,

as we have moved a different path, and we keep the "reference" on the ET (see other issues and feature tracks here)

matzew avatar Jun 27 '23 12:06 matzew

/assign @matzew

matzew avatar Jun 27 '23 12:06 matzew

/close

as per comments above

matzew avatar Sep 04 '23 08:09 matzew

@matzew: Closing this issue.

In response to this:

/close

as per comments above

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

knative-prow[bot] avatar Sep 04 '23 08:09 knative-prow[bot]