pymorphy2 icon indicating copy to clipboard operation
pymorphy2 copied to clipboard

Support 3.11 inspect.getfullargspec

Open kuk opened this issue 3 years ago • 7 comments

kuk avatar Jan 17 '23 14:01 kuk

@kuk. IMO it's better to do CI related commits in a separate PR, not in PR titled as "Support 3.11 inspect.getfullargspec"

insolor avatar Jan 18 '23 08:01 insolor

@insolor Fixed, now PR only for 3.11

Also turns out DAWG does not work fo 3.10, 3.11 https://github.com/pytries/DAWG/issues/49. So pymorpy2[fast] still broken for 3.11. But this is maybe for future PRs

kuk avatar Jan 18 '23 10:01 kuk

This is a much needed change. Thank you, kuk! I'd only suggest to make it simpler and use inspect.getfullargspec right away, since inspect.getargspec is deprecated since 3.0. This 1 line should be all that is needed: args = inspect.getfullargspec(cls.__init__).args

Но действительно, странно, что в проекте на было комитов уже давно...

poedator avatar Jan 22 '23 08:01 poedator

Pymorphy currently also supports python 2, do not want to break with this PR

kuk avatar Jan 22 '23 14:01 kuk

@kmike, merge, please :)

insolor avatar Feb 08 '23 08:02 insolor

Could anyone please advice, is pymorphy dead?

darzanebor avatar Feb 13 '24 17:02 darzanebor

@darzanebor the original pymorphy2 can be considered dead. I suggest you to use https://github.com/no-plagiarism/pymorphy3.

Long story: #160

insolor avatar Feb 14 '24 06:02 insolor