ffmpeg-python icon indicating copy to clipboard operation
ffmpeg-python copied to clipboard

Time for a new release?

Open petterreinholdtsen opened this issue 2 years ago • 9 comments

I notice the last release of ffmpeg-python was released in 2019. Perhaps it is time to wrap up a new release? Is this library still being maintained? The number of open pull requests and issues make me wonder. If it is, I would love to see this library distributed from the Debian project to become available in all the Linux distributions derived from Debian, like Ubuntu and Kali. Is this something you would be interested in making happen?

petterreinholdtsen avatar Apr 10 '23 06:04 petterreinholdtsen

The OpenHub project indicators on https://openhub.net/p/ffmpeg-python have some worrying observations.

petterreinholdtsen avatar Apr 16 '23 04:04 petterreinholdtsen

The request for packaging of ffmpeg-python in Debian is https://bugs.debian.org/1034286 . Because of the amount of response here as well the number of open issues and pull requests I decided to not push forward to get ffmpeg-python in Debian and instead adjust OpenAI Whisper to work without it.

petterreinholdtsen avatar Apr 16 '23 21:04 petterreinholdtsen

@petterreinholdtsen Should we be using this library instead?

https://github.com/jonghwanhyeon/python-ffmpeg

Have you had time to review the library by jonghwanhyeon?

Guix contributor, Parnikkapore, recently submitted a patch to GNU Guix for this library but the latest release has some incompatibilities with our latest packaged CPython requiring patching imports:

https://issues.guix.gnu.org/64732#7

I wonder if we should just use a more up to date ffmpeg-python from else somewhere instead.

jgarte avatar Jul 22 '23 12:07 jgarte

(It's a me! 😀)

AFAICT this library is primarily a more friendly surface syntax for FFmpeg filtergraphs (read: a way to write filtergraphs more python-ically); neither python-ffmpeg nor imageio-ffmpeg fulfills this task AFAICT.

Whisper does not need to dynamically build up a filtergraph, so it can hard-code the arguments.

Unfortunately for me, r128gain does.

parnikkapore avatar Jul 22 '23 13:07 parnikkapore

For any future souls surfacing this in a search, ffmpegio has a filtergraph builder and is still maintained as of this writing. Not as perused as this one though.

parnikkapore avatar Jul 22 '23 13:07 parnikkapore

@parnikkapore Hi!

Reading through the docs for python-ffmpeg, I can see how python-ffmpeg doesn't have the API niceties that ffmpeg-python does.

@parnikkapore I think we should choose a later commit of ffmpeg-python instead of patching the old release. Could you send a v4 to Guix for that and add a comment describing why near the let statement specifying the commit hash?

Let's continue the thread over at #64732 on the mumi bug tracker.

jgarte avatar Jul 22 '23 13:07 jgarte

For any future souls surfacing this in a search, ffmpegio has a filtergraph builder and is still maintained as of this writing. Not as perused as this one though.

Nice __idea__.

jgarte avatar Jul 22 '23 14:07 jgarte

Is repository still being maintained?

kyrlon avatar Apr 10 '24 19:04 kyrlon