selenium_firefox icon indicating copy to clipboard operation
selenium_firefox copied to clipboard

added webdriver_manager support to auto-install gecko webdriver

Open yanncabral opened this issue 5 years ago • 1 comments

Thus, there is no need to manually download and install the Gecko Webdriver compatible with the user platform.

yanncabral avatar Aug 24 '20 04:08 yanncabral

Hey, first of all thanks for the pr. Does this lib download/install/use a new geckodriver even if I have one installed already? Also a better aproach would be:

  • get a geckodriver_path(Optional[string] = None) on the init
  • check if the variable is not None, and if there actually something located at that path
  • if not, check if there is geckodriver installed to the default_path (if default_path != geckodriver_path) (/usr/local/bin/geckodriver on mac)
  • if still nothing, use auto-innstall

This approach leaves the ability to the user to have control over what version of geckodriver they would like to use

kkristof200 avatar Aug 26 '20 07:08 kkristof200