python-for-android icon indicating copy to clipboard operation
python-for-android copied to clipboard

Can/should we get rid of zope_interface's fix-init patch ?

Open Cheaterman opened this issue 1 year ago • 2 comments

https://github.com/kivy/python-for-android/blob/10c529261d1cb19f1873bcf31db4e3f88c099488/pythonforandroid/recipes/zope_interface/init.py#L22

If you check on Kivy Discord (or even in buildozer issues: kivy/buildozer#1601), there's a few mentions (including mine) of twisted failing to build because of zope_interface. It seems to work properly if we remove the fix-init patch, so maybe we're indeed in the future (cf comment in the recipe) and this errors out?

I opened this issue (instead of directly making a PR) to discuss the situation, in particular to check if people manage to properly build projects that use twisted without issues, in which case maybe the fix-init patch isn't the root cause.

Cheaterman avatar Nov 16 '24 12:11 Cheaterman

Thanks for the report. I would say if it doesn't even build and fail at patching with zope interface, I don't see why not removing it indeed. In the worst case it fails runtime, but it's still some steps further. So yeah feel free to come up with a pull request

AndreMiras avatar Nov 17 '24 20:11 AndreMiras

It looks like the file is there since last year: https://github.com/zopefoundation/zope.interface/blob/master/src/zope/interface/init.py

guysoft avatar Jul 24 '25 22:07 guysoft