subtitleeditor icon indicating copy to clipboard operation
subtitleeditor copied to clipboard

Subtitle Editor adds bookmark with empty href to recently used files list

Open lucaswerkmeister opened this issue 4 years ago • 0 comments

Subtitle Editor seems to have added the following entry to my ~/.local/share/recently-used.xbel file:

  <bookmark href="" added="2021-11-26T18:30:28.481200Z" modified="2021-11-26T18:30:28.481205Z" visited="2021-11-26T18:30:28.481201Z">
    <desc></desc>
    <info>
      <metadata owner="http://freedesktop.org">
        <mime:mime-type type=""/>
        <bookmark:groups>
          <bookmark:group>subtitleeditor-waveform</bookmark:group>
        </bookmark:groups>
        <bookmark:applications>
          <bookmark:application name="subtitleeditor" exec="&apos;subtitleeditor&apos;" modified="2021-11-26T18:30:28.481203Z" count="1"/>
        </bookmark:applications>
      </metadata>
    </info>
  </bookmark>

The empty href attribute doesn’t seem very useful, and can confuse other applications trying to parse the file. (Technically, the desktop-bookmark-spec says the href should be a URI, and I don’t think the empty string is a valid URI.)

Steps to reproduce:

  • open Subtitle Editor
  • create a new subtitle file (Ctrl+N)
  • open a video (Ctrl+Shift+M and then select a video file)
  • generate waveform from video

The bookmark is added to the file as soon as you select the “generate waveform from video” step; you don’t actually need to save the waveform to a file in the following dialog.

lucaswerkmeister avatar Nov 27 '21 14:11 lucaswerkmeister