subtitleeditor icon indicating copy to clipboard operation
subtitleeditor copied to clipboard

Improve the Set Start from Player action, so that it can move a whole selection of subtitles.

Open eltomito opened this issue 4 years ago • 3 comments

The anctent Set Start From Player action moves the selected subtitle to the current player position. But when more than 1 subtitles are selected, it just moves the first one anyway. This is where this pull request comes to the rescue and saves the day: It makes this action move all the selected subtitles to the new player position as a block... and then walks off into the sunset.

eltomito avatar Sep 21 '21 20:09 eltomito

Hm, I am not sure if it did not make more sense to move the suceeding subtitles by the same amount. Ergo lets say we have subtitles A B and C starting at 0:00:01,000, 0:00:02,000 and 0:00:03,000 respectively. Lets say we have the player at position 0:00:04,000. Set start from player would then set the new starts to 0:00:04,000, 0:00:05,000 and 0:00:06,000 respecitvely.

Why would you want to have many subtitles start at the same time?

felagund avatar Sep 22 '21 08:09 felagund

The patch does exactly what you say. I guess my explanation wasn't clear.

T  


Od: "Tomáš Hnyk" @.> Komu: "kitone/subtitleeditor" @.> Datum: 22.09.2021 10:32 Předmět: Re: [kitone/subtitleeditor] Improve the Set Start from Player action, so that it can move a whole selection of subtitles. (#50)

  Hm, I am not sure if it did not make more sense to move the suceeding subtitles by the same amount. Ergo lets say we have subtitles A B and C starting at 0:00:01,000, 0:00:02,000 and 0:00:03,000 respectively. Lets say we have the player at position 0:00:04,000. Set start from player would then set the new starts to 0:00:04,000, 0:00:05,000 and 0:00:06,000 respecitvely. Why would you want to have many subtitles start at the same time? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kitone/subtitleeditor/pull/50#issuecomment-924705677, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABS2WC3YMHB7VUQBJOUG3TDUDGIAFANCNFSM5EPU3BMQ. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

eltomito avatar Sep 22 '21 10:09 eltomito

Great! This would implement "move subtitles to position" which is now possible with cuting and pasting them but it is slowish (a few seconds of lag).

felagund avatar Sep 22 '21 11:09 felagund