subtitleeditor icon indicating copy to clipboard operation
subtitleeditor copied to clipboard
verified publisher icon kitone

Fix Wayland support in OpenGL video output

Open xhaakon opened this issue 5 years ago • 3 comments

Make the video play inside the multimedia pane, not open its own window.

Before: Screenshot from 2020-02-10 12-01-18

After: Screenshot from 2020-02-10 11-55-04

xhaakon avatar Feb 10 '20 12:02 xhaakon

Hi, thanks for the pull and sorry for the delay. I don't have time to debug it, but a quick test make the application crash :

X Error of failed request: BadWindow (invalid Window parameter) Major opcode of failed request: 3 (X_GetWindowAttributes) Resource id in failed request: 0x26543b0 Serial number of failed request: 54 Current serial number in output stream: 55

kitone avatar Feb 22 '20 16:02 kitone

Hi, I get this error when the video output in the preferences is set to Autodetect. Apparently autovideosink element makes a wrong choice on Wayland, instantiating an X11 video sink.

I guess we'll have to limit the choice of video outputs when Wayland gets detected and keep only OpenGL, and perhaps SDL.

xhaakon avatar Feb 24 '20 12:02 xhaakon

Hi, I added another change that forces the application to use OpenGL video output when it's running on Wayland. This should prevent the crash due to X11 error you mentioned above.

xhaakon avatar Mar 07 '20 12:03 xhaakon