All-In-One-Python-Projects icon indicating copy to clipboard operation
All-In-One-Python-Projects copied to clipboard

Contribution to Issue #14 - Added python script for expense splitter

Open rkt-1597 opened this issue 1 year ago • 2 comments

@king04aman This PR implenents an expense splitter python script.

rkt-1597 avatar Oct 09 '24 08:10 rkt-1597

Thank you for your contribution! The expense splitter script is a solid start, and I appreciate your effort. To enhance it further, consider adding docstrings to your functions for clarity, implementing input validation to ensure users enter valid amounts, and making the confirmation input case-insensitive for a better user experience. Additionally, please follow the contributing guidelines by including a requirements.txt file for dependencies and a README.md to explain how to use the script, along with a runtime file to specify the Python version. These changes will improve the maintainability of your code.

king04aman avatar Oct 09 '24 19:10 king04aman

Yes

rkt-1597 avatar Oct 10 '24 02:10 rkt-1597

@king04aman , the requirements.txt file would be empty in this case, as there is no particular python library used in this script, right?

rkt-1597 avatar Oct 10 '24 13:10 rkt-1597

The script lacks input validation, potentially causing errors if users enter non-integer values or invalid inputs. Variable names such as chk1, n, a, num, and amt are unclear and should be renamed for better understanding (e.g., add_members, member_name, contribution, total_members, and contributions) also consider adding **README.md** file

king04aman avatar Oct 12 '24 16:10 king04aman