basic_neural_network icon indicating copy to clipboard operation
basic_neural_network copied to clipboard

wrong hidden error computation

Open Orbiter opened this issue 4 years ago • 0 comments

in your lines https://github.com/kim-marcel/basic_neural_network/blob/master/src/main/java/basicneuralnetwork/NeuralNetwork.java#L165-L169

                weights[n - 1] = weights[n - 1].plus(deltas);

                // Calculate and set target for previous (next) layer
                SimpleMatrix previousError = weights[n - 1].transpose().mult(errors);
                target = previousError.plus(layers[n - 1]);

you calculate the target for the next (lower) level using the matrix previousError. That uses the weights weights[n - 1] which had previously been altered with the correction factor. What you require here is the unaltered weight to make the lower layer of the network backpropagation dependent on the original error with the original weight, not the altered weight.

From my point of view this can be fixed by moving the previousError line above the weights computation, like:

                SimpleMatrix previousError = weights[n - 1].transpose().mult(errors);
                weights[n - 1] = weights[n - 1].plus(deltas);
                target = previousError.plus(layers[n - 1]);

Orbiter avatar Jul 23 '21 11:07 Orbiter