solder

solder copied to clipboard

…pointer

karnauskas

https://github.com/php/php-src/blob/master/ext/standard/info.c#L1111-L1146

davidcole1340

Segmentation fault (core dumped)

2

If take example and `hello_world` function like this: ```php ``` It will crash with segmentation fault (core dumped) looks like problem in add_zend_value_zval

Norbytus

The patch described in #5 works on my machine.

wizzwizz4

php_echo is vulnerable to format string attacks!

1

`solder::zend::php_echo` is implemented as: php_printf(c_message.as_bytes_with_nul().as_ptr() as *const i8); but it should be something like: php_printf(c_str!("%s"), c_message.as_bytes_with_nul().as_ptr() as *const i8); (Please check that this works before using it; it's untested unsafe...

wizzwizz4

Not enough unsafe

1

Several APIs inside solder should be marked unsafe, but aren't. From the Nomicon: > The `unsafe` keyword has two uses: to declare the existence of contracts the compiler can't check,...

wizzwizz4