nova-rust icon indicating copy to clipboard operation
nova-rust copied to clipboard

[BUG] Minor syntax highlighting issue

Open adamierymenko opened this issue 3 years ago • 5 comments

Describe the bug There's a minor syntax highlighting issue with the use of function generic parameters like Fn() and FnOnce().

To Reproduce See attached screenshot for an example. Note that the highlighter reverts to white and basically stops highlighting until something resets it inside the function.

Expected behavior Correct syntax highlighting.

Screenshots Screen Shot 2022-08-23 at 6 14 57 PM

Versions (please complete the following information):

  • macOS Big Sur
  • Processor: Apple Silicon
  • Nova 9.5

adamierymenko avatar Aug 23 '22 22:08 adamierymenko

Saw this again. Seems like function types have their -> misinterpreted as a template parameter or something.

adamierymenko avatar Oct 20 '22 15:10 adamierymenko

BTW -- if you make this project sponsorable I'll throw you a sponsorship. I use this daily.

adamierymenko avatar Oct 20 '22 15:10 adamierymenko

Thanks for the vote of confidence – it really means a lot!

I apologize for not responding to this issue sooner, but I had a busy summer and now Nova 10 is coming in hot with Tree Sitter as its parsing engine. The good news is that many folks better than me at this sort of thing have written a Tree Sitter grammar so glaring issues like this should be rarer. I'm currently working on connecting the Tree Sitter syntax tree to Nova theme selectors and symbols. Nova 10 will likely show up before I'm ready, but I hope to follow its release shortly.

kilbd avatar Oct 20 '22 15:10 kilbd

Ahh nice. Sounds like it'll make your job easier since you'll just have to worry about the rust language server stuff.

Your plugin still works better than Rust for VSCode which is crash city when using rust-analyzer and leaves zombie Rust language parser processes running that have to be manually killed (at least on macOS/ARM64).

adamierymenko avatar Oct 23 '22 17:10 adamierymenko

Please let me know if this is still an issue in the latest version (if you're still using this extension). Thanks!

kilbd avatar Mar 17 '23 16:03 kilbd