android-oss icon indicating copy to clipboard operation
android-oss copied to clipboard

MBL-2337 && MBL-2341 && MBL-2339: Location filter

Open Arkariang opened this issue 8 months ago • 1 comments

📲 What

  • New filter added to the search experience

🤔 Why

  • Now able to filter projects by locations

🛠 How

  • Feature flag code has been move, before it ws gating %raised, now it gated "Location", therefore if feature flag off, Location filter won't be visible on the UI
  • Using locations query
  • Adding a new parameter to projects query
  • A bunch of new UI

👀 See

https://github.com/user-attachments/assets/10a3c6b0-a609-4f34-b7d2-f1a77b303a73

| --- | --- | | | |

📋 QA

  • As logged in user it will show 1 default location (by your IP). 📥 this piece differs from the website no 1:1 comparison here
  • Search by locations, throw in there more filter

Story 📖

MBL-2337 MBL-2339 MBL-2241

Arkariang avatar Jun 12 '25 15:06 Arkariang

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 42.77778% with 103 lines in your changes missing coverage. Please review.

Project coverage is 66.34%. Comparing base (dfe43a7) to head (bf0f288).

Files with missing lines Patch % Lines
...arter/ui/activities/compose/search/SearchScreen.kt 21.51% 53 Missing and 9 partials :warning:
...arter/ui/activities/compose/search/SearchTopBar.kt 52.27% 19 Missing and 2 partials :warning:
...rter/ui/activities/compose/search/LocationSheet.kt 54.05% 9 Missing and 8 partials :warning:
...r/features/search/viewmodel/FilterMenuViewModel.kt 85.71% 2 Missing :warning:
...activities/compose/search/FilterMenuBottomSheet.kt 66.66% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2345      +/-   ##
============================================
- Coverage     66.42%   66.34%   -0.08%     
  Complexity     2296     2296              
============================================
  Files           371      371              
  Lines         26254    26335      +81     
  Branches       3952     3968      +16     
============================================
+ Hits          17438    17473      +35     
- Misses         6795     6825      +30     
- Partials       2021     2037      +16     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Jun 16 '25 19:06 codecov-commenter

Sorry forgot the video

https://github.com/user-attachments/assets/a0561f10-8f8a-4413-9ddd-019de5aa4ce6

tonyteate avatar Jun 17 '25 21:06 tonyteate

Sorry forgot the video

Screen_recording_20250617_162957.mp4

Such a keen eye tony as usual! still need to tackle the polish ticket in which the selected location+ reset enable/disable depending on suggestions results + adding the location on Main Filter

Arkariang avatar Jun 17 '25 21:06 Arkariang