android-oss icon indicating copy to clipboard operation
android-oss copied to clipboard

[MBL-823] Update ProjectNotificationViewmodel to RX2

Open mtgriego opened this issue 1 year ago • 1 comments

📲 What

Updating the viewmodel and relevant view code and tests to Rx2

🤔 Why

RX1 ❌ RX2 ✔️

🛠 How

🧠

📋 QA

Confirm that the views in the notification settings page for individual projects works as expected

Story 📖

MBL-823

mtgriego avatar Aug 27 '24 23:08 mtgriego

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 75.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 67.65%. Comparing base (25bf865) to head (dd7f3d8). Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...starter/viewmodels/ProjectNotificationViewModel.kt 75.00% 3 Missing and 2 partials :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2114      +/-   ##
============================================
+ Coverage     67.51%   67.65%   +0.13%     
- Complexity     2133     2189      +56     
============================================
  Files           364      367       +3     
  Lines         22186    22567     +381     
  Branches       3116     3237     +121     
============================================
+ Hits          14979    15267     +288     
+ Misses         5568     5564       -4     
- Partials       1639     1736      +97     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Aug 28 '24 17:08 codecov-commenter