android-oss icon indicating copy to clipboard operation
android-oss copied to clipboard

MBL-1475 Add backing details navigation

Open ycheng-kickstarter opened this issue 1 year ago • 1 comments

📲 What

When tapping the project title and thumbnail area of the card, app should open a webview that loads the backing details url

🤔 Why

🛠 How

PPO cards are currently not hooked up to a backend query, so instead I added a backingDetailsUrl field to the PPOCardDataMock data object for now with a test url. Obviously once we hook up real PPO cards this test url should be replaced with the backend-provided url for the backing details.

👀 See

Hamburger menu -> Alerts -> tap on pledge summary view: 2662122e-016c-4181-9aca-ea81c1f2dc58

https://github.com/kickstarter/android-oss/assets/129205442/a46b9b39-2d74-4937-b807-5f047c0cde82

📋 QA

To get PPO cards to show up, on line 15 of the VM, replace private val ppoCards = MutableStateFlow<PagingData<PPOCardDataMock>>(PagingData.empty()) with mock data: private val ppoCards = MutableStateFlow<PagingData<PPOCardDataMock>>( PagingData.from( listOf( PPOCardDataMock(shippingAddress = "Firsty Lasty\n123 First St Apt #5678\nLos Angeles, CA 90025-1234\nUnited States", viewType = PPOCardViewType.CONFIRM_ADDRESS) ) ) )

Tapping the pledge summary view will open up the test url https://www.kickstarter.com/projects/thehoneycouple/the-honey-couples-building-expansion

Story 📖

https://kickstarter.atlassian.net/browse/MBL-1475

ycheng-kickstarter avatar Jun 26 '24 20:06 ycheng-kickstarter

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 85.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 68.07%. Comparing base (2ddec7c) to head (fbebe9d).

Files Patch % Lines
.../kickstarter/viewmodels/BackingDetailsViewModel.kt 84.21% 2 Missing and 1 partial :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2064      +/-   ##
============================================
+ Coverage     68.06%   68.07%   +0.01%     
- Complexity     2113     2114       +1     
============================================
  Files           355      356       +1     
  Lines         21652    21671      +19     
  Branches       3050     3051       +1     
============================================
+ Hits          14737    14753      +16     
- Misses         5273     5275       +2     
- Partials       1642     1643       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jun 27 '24 18:06 codecov-commenter