NotificationNotes icon indicating copy to clipboard operation
NotificationNotes copied to clipboard

Add share note with other apps function

Open diegoalvis opened this issue 8 years ago • 3 comments

diegoalvis avatar Oct 24 '17 14:10 diegoalvis

@khuttun is possible that you must upgrade your gradle plugin version, but if you have troubles let me know. Have a nice day!

diegoalvis avatar Oct 24 '17 14:10 diegoalvis

Hi @diegoalvis. Thanks for the pull request! The code looks good. Some comments:

  • Could you leave the changes outside app/src out from the commit? They are not directly related to adding the share functionality.

  • Now that I look at the implementation, I started to think that should the share button actually rather be in the Edit note view next to the SAVE button? The notes list looks a bit busy now with the share buttons, and the button actually might go on top of the note text.

khuttun avatar Oct 24 '17 19:10 khuttun

Ok man, @khuttun

diegoalvis avatar Oct 24 '17 20:10 diegoalvis