NonEmptyArray icon indicating copy to clipboard operation
NonEmptyArray copied to clipboard

Add `Codable` Conformance

Open chrisbrandow opened this issue 7 years ago • 2 comments

Not to be flippant, but I was curious to use this class, but I needed codable conformance. I added it, and thought I'd express my appreciation by sharing it.

However, this was done quickly and while it seems to work, I haven't added any tests.

chrisbrandow avatar Jul 24 '18 21:07 chrisbrandow

this PR is causing me a lot of internal strife because there are a few bugs in this library (namely with the variadic initializer and operator support) and https://github.com/pointfreeco/swift-nonempty is better in some ways (more compiler safe), and i don't have a ton of time to fix this up. i do want tests before we merge this but i also don't want to suggest to anyone that this is really production ready.

khanlou avatar Jul 26 '18 18:07 khanlou

Cool. If I get some time soon, I'll add some tests. but don't feel any obligation to merge on my behalf.

chrisbrandow avatar Jul 27 '18 19:07 chrisbrandow