keystone icon indicating copy to clipboard operation
keystone copied to clipboard
verified publisher icon keystone-engine

Undefined DEBUG for DataDirectoryIndex.

Open rwindegger opened this issue 7 years ago • 3 comments

rwindegger avatar Aug 01 '18 11:08 rwindegger

interesting, can you please describe more on about issue?

aquynh avatar Aug 02 '18 02:08 aquynh

So after looking at it again I think there is more going on than I changed.

  1. I had -DDEBUG required by one of the other dependencies for some debug output. That led to a build error in that line.

  2. I just saw that LLVM defines a Macro for DEBUG as well. I think that macro is broken after that change is included. As DEBUG is undefined and redefined with a wrong value in that case. That case also does not trigger the compile error as in that case DEBUG is defined as DEBUG(X) see https://github.com/keystone-engine/keystone/blob/0ab2b81261d02a3376de327d6214f93a620d2c59/llvm/include/llvm/Support/Debug.h#L85

rwindegger avatar Aug 02 '18 18:08 rwindegger

why do you disable fuzz?

aquynh avatar Dec 27 '18 01:12 aquynh