keymanapp
chore(common,developer): expand 'x' to 'compileContext'
- rename ObjectWithMetadata to ObjectWithCompileContext
- fixup docs in boxXmlArray
- rename 'x' property and parameter to 'compileContext'
Fixes: #14117
@keymanapp-test-bot skip
User Test Results
Test specification and instructions
User tests are not required
Test Artifacts
-
Android
- Keyman for Android apk
- FirstVoices for Android 16.0 apk
- FirstVoices Keyboards for Android apk
- KeyboardHarness apk - build pending
- Keyman for Android 16.0 apk
- KMSample1 apk - build pending
- KMSample2 apk - build pending
- Web
![keymanapp-test-bot[bot] avatar](https://avatars.githubusercontent.com/in/133554?v=4 "Published by a pub.dev verified publisher"){kind=small}
Two files to take out of this PR, otherwise all good.
I am slightly puzzled as to why we have stuff relating to XML in common/web/types rather than in developer/. kmx-plus is not used in any of our JS code, just consumed by core, so we shouldn't have a need for any of that in common/ I would have thought. I may be forgetting something.
Not xml per se. But the kmx-plus level APIs (the in memory stuff) for in this case element string construction are in common/web/types and so to be able to pass compileContext to them i hoisted the compileContext type to common/web/types
I'd be ok with moving common/web/types/src/kmx over to developer/.. but that's not where it is now and need to make sure all of the dependentants can call into developer/
