keyman icon indicating copy to clipboard operation
keyman copied to clipboard
verified publisher icon keymanapp

feat(android): standardize keyboard min max heights + docs

Open MattGyverLee opened this issue 10 months ago • 3 comments

Follow-up work from other resizing work.

MattGyverLee avatar Apr 03 '25 17:04 MattGyverLee

User Test Results

Test specification and instructions

keymanapp-test-bot[bot] avatar Apr 03 '25 17:04 keymanapp-test-bot[bot]

This pull request is from an external repo and will not automatically be built. The build must still be passed before it can be merged. Ask one of the team members to make a manual build of this PR.

keyman-server avatar Apr 03 '25 17:04 keyman-server

FYI, we recognize the Keyman for Android APIs need a deep power clean, so we're tentatively going to spend a week during 19.0 to hash it out (maybe end of Sept into early Oct )

See holding issue #13636

darcywong00 avatar Apr 04 '25 02:04 darcywong00

@darcywong00 what is the status of this?

mcdurdin avatar Oct 13 '25 15:10 mcdurdin

@darcywong00 @mcdurdin

I believe this PR is ready now.

MattGyverLee avatar Nov 13 '25 16:11 MattGyverLee

@darcywong00 @mcdurdin

I believe this PR is ready now.

Thanks Matt. We'll need to also include some test procedures on the PR. Do you think the tests in #14472 work?

darcywong00 avatar Nov 14 '25 04:11 darcywong00

We also need to bring this branch up to date with its base (master) so we can be sure that we are testing the latest set of changes, as it is a bit stale currently.

mcdurdin avatar Nov 14 '25 04:11 mcdurdin

This has been rebased onto master. Requesting Review by @darcywong00 or @mcdurdin

MattGyverLee avatar Nov 21 '25 20:11 MattGyverLee

Here's the bug in action: https://github.com/user-attachments/assets/7d919ada-d5ab-4cc3-96e4-640eab36443e

@mcdurdin You can see that I made a draggable bar for the App Builder interface instead of the Keyman "marching ants". It feels more obviously grabbable to me. Screenshot_20251122-030813.png

Also, I send the size percentages back to the settings activity and show them there. Screenshot_20251122-030556.png

Let me know if you want to move either direction (in a separate PR, of course). I could easily port the Grab Bar over to the KM app. The percentages might take more time.

MattGyverLee avatar Nov 22 '25 08:11 MattGyverLee

@MattGyverLee - let me know when you're done resolving review comments and I'll trigger a build for User Testing

darcywong00 avatar Nov 25 '25 08:11 darcywong00

Test Specification

  1. Android Studio, Pixel 8a API 34 Emulator.
  2. MacBook Pro

Installation

  1. Artifacts > release > keyman-19.0.166-alpha-test-13663.apk

Test Results

  • TEST_KEYMAN (PASSED):
  1. Launch Keyman for Android --> Dismiss the Startup Dialog
  2. Go to settings --> Adjust keyboard height
  3. On Portrait, drag the keyboard to 50% of the screen
  4. Rotate the screen to landscape, drag the keyboard to 75% of the screen
  5. Click back --> back to home screen
  6. Verified: The keyboard heights (portrait and landscape) match the customization.
  7. Close, clear and open the app
  8. Verified: The keyboard heights are still in the customized heights.
  9. Go to settings --> Adjust keyboard height --> "Reset to defaults" in both portrait and landscape orientation
  10. Close, clear and open the app
  11. Verified: The keyboard heights are back to default.
  12. Verified: Type and use the predictive text work as expected.

Meng-Heng avatar Dec 01 '25 02:12 Meng-Heng

Changes in this pull request will be available for download in Keyman version 19.0.168-alpha

keyman-server avatar Dec 01 '25 18:12 keyman-server