keyman icon indicating copy to clipboard operation
keyman copied to clipboard

feat(ios): configurable keyboard height

Open sgschantz opened this issue 1 year ago • 1 comments

In progress...draft PR to use with TestFlight during development

Fixes #5897

@keymanapp-test-bot skip

sgschantz avatar Oct 23 '24 12:10 sgschantz

User Test Results

Test specification and instructions

  • TEST_PORTRAIT_KEYBOARD_HEIGHT_ADJUSTMENT (PASSED) (notes)
  • TEST_LANDSCAPE_KEYBOARD_HEIGHT_ADJUSTMENT (PASSED) (notes)
  • TEST_SYSTEM_KEYBOARD_HEIGHT_ADJUSTMENT (PASSED) (notes)
  • TEST_ADJUST_KEYBOARD_ROTATION (PASSED) (notes)
  • TEST_ADJUST_KEYBOARD_DARK_MODE (PASSED) (notes)
  • TEST_RESET_TO_DEFAULT (PASSED) (notes)

Test Artifacts

keymanapp-test-bot[bot] avatar Oct 23 '24 12:10 keymanapp-test-bot[bot]

Test Results

I tested this issue with the attached "Keyman 18.0.130-alpha-test-12571" build(test flight) on the iOS 17.4, iPhone 13 physical device.

  • TEST_PORTRAIT_KEYBOARD_HEIGHT_ADJUSTMENT (Passed):
  1. I installed the Keyman 18.0.130-alpha-test-12571 version.
  2. Open the Keyman app. Go to the keyman settings.
  3. iPhone device holds in portrait view. Tap on the "Adjust Keyboard Height" option.
  4. Drag the resizer arrow to adjust the height of the keyboard(Small to Big Height).
  5. Tap the Back button.
  6. Tap the Done button. In Keyman editor: Verified that the keyboard resized within the Keyman app.
  • TEST_LANDSCAPE_KEYBOARD_HEIGHT_ADJUSTMENT (Passed):
  1. I installed the Keyman 18.0.130-alpha-test-12571 version.
  2. Open the Keyman app. Go to the keyman settings.
  3. iPhone device holds in landscape view. Tap on the "Adjust Keyboard Height" option.
  4. Drag the resizer arrow to adjust the height of the keyboard(Big Height to Small).
  5. Tap the Back button
  6. Tap the Done button In Keyman editor: Verified that the keyboard resized within the Keyman app.
  • TEST_SYSTEM_KEYBOARD_HEIGHT_ADJUSTMENT (Passed):
  1. I installed the Keyman 18.0.130-alpha-test-12571 version.
  2. Open the Keyman app. Go to the keyman settings.
  3. iPhone device holds in portrait view. Tap on the "Adjust Keyboard Height" option.
  4. Drag the resizer arrow to increase the small to Big height of the keyboard.
  5. Tap the Back button
  6. Tap the Done button
  7. Set the keyman keyboard as a system keyboard by clicking keyman/Settings/System Keyboard Settings/Keyboards/Allow full access & Keyman
  8. Open the Pages app. Open a blank page.
  9. Click on the blank page.
  10. In Keyman editor: Verified that the keyboard resized with bigger.
  • TEST_ADJUST_KEYBOARD_ROTATION (Passed):
  1. I installed the Keyman 18.0.130-alpha-test-12571 version.
  2. Open the Keyman app. Go to the keyman settings.
  3. iPhone device holds in portrait view. Tap on the "Adjust Keyboard Height" option.
  4. Rotate the device from portrait to landscape
  5. Verified that the keyboard animation appeared as small size in the landscape view.
  6. Rotate the device from landscape to portrait.
  7. Verified that the keyboard height appeared as a bigger size in the portrait view.
  8. Verified that the keyboard UI appeared correctly when rotating the view in the phone.
  • TEST_ADJUST_KEYBOARD_DARK_MODE (Passed):
  1. I installed the Keyman 18.0.130-alpha-test-12571 version.
  2. Open the Keyman app. Go to the keyman settings.
  3. iPhone device holds in portrait view. Tap on the "Adjust Keyboard Height" option.
  4. Change the iPhone theme from light to dark mode.
  5. Verified that the keyboard animation appeared in the dark view.
  6. Verified that the white background appeared with blue & black text.
  7. Verified that the blue text is clickable.
  • TEST_RESET_TO_DEFAULT (Passed):
  1. I installed the Keyman 18.0.130-alpha-test-12571 version.
  2. Open the Keyman app. Go to the keyman settings.
  3. iPhone device holds in portrait view. Tap on the "Adjust Keyboard Height" option.
  4. Drag the resizer arrow to adjust the height of the keyboard(Small to Big Height).
  5. Tap the Back button
  6. Tap the Done button
  7. In Keyman editor: Verified that the keyboard resized within the Keyman app.
  8. Go to the keyman settings. Tap on the "Adjust Keyboard Height" option.
  9. Click on the 'Rest to Default Keyboard Height' button.
  10. Verified that the keyboard is reset to the default size on the keyboard animation.
  11. Tap the Back button
  12. Tap the Done button
  13. In Keyman editor: Verified that the keyboard appeared as the default size in the Keyman app.

dinakaranr avatar Dec 09 '24 14:12 dinakaranr

Changes in this pull request will be available for download in Keyman version 18.0.160-alpha

keyman-server avatar Dec 16 '24 18:12 keyman-server