keyman icon indicating copy to clipboard operation
keyman copied to clipboard

refactor(web): spin off deduplication, suggestion-similarity sections 📚

Open jahorton opened this issue 1 year ago • 1 comments

Continuing from #11899, this spins of the suggestion-deduplication and the suggestion-similarity-detection sections into their own methods. The two were a bit entangled, so it was simplest to split them off at the same time.

While no unit tests are added here for either, these changes will make it much simpler to establish some that are focused solely on each of the two methods in the future.

@keymanapp-test-bot skip

jahorton avatar Jul 02 '24 03:07 jahorton

Is there a set of regression tests we can run on the whole predict() function after these refactors?

There's a pretty solid set of automated tests that have really helped me out in this regard while developing. They've helped catch a number of issues during this process... and I've also added more automated tests to further validate everything.

I don't know if there's an extensive set of regression user tests yet or not. If desired, I could spend some time drafting some; I've become more aware of various limitations and edge cases as a result of all of this.

jahorton avatar Jul 23 '24 07:07 jahorton

Changes in this pull request will be available for download in Keyman version 18.0.75-alpha

keyman-server avatar Jul 25 '24 18:07 keyman-server