keyman icon indicating copy to clipboard operation
keyman copied to clipboard

refactor(web): extract suggestion-finalization block into its own function 📚

Open jahorton opened this issue 1 year ago • 1 comments

After working again with the main method for generating predictions over the past few PRs, I got reminded of just how long that method is. This was further complicated after recognizing issues regarding near-match suggestion prioritization (#11876).

With a bit of effort, we should be able to spin off individual 'sections' of the predict method into their own individual functions. This would help clarify exactly what each section specifically needs and increase code clarity for future maintainers.

For simplicity of review, I'll be doing one section at a time, working from bottom-to-top. Each section has effects for those that follow it, so this should minimize the number of cross-effects for the PR set as a whole.

@keymanapp-test-bot skip

jahorton avatar Jul 02 '24 02:07 jahorton

Changes in this pull request will be available for download in Keyman version 18.0.75-alpha

keyman-server avatar Jul 25 '24 18:07 keyman-server