keyman icon indicating copy to clipboard operation
keyman copied to clipboard

fix(android): trigger relayout if height values are mismatched on keyboard resize

Open jahorton opened this issue 1 year ago • 3 comments

Fixes: #11830

User Testing

TEST_ROTATIONS: Ensure that the Android system keyboard rotates properly as the device orientation is changed.

TEST_RESTORE_FROM_BACKGROUND: Ensure that when the app is backgrounded and then restored, the keyboard is scaled properly.

jahorton avatar Jun 20 '24 03:06 jahorton

User Test Results

Test specification and instructions

  • TEST_ROTATIONS (PASSED): I tested this issue with the attached "Keyman-18.0.59-alpha-test-11838" build on the Android 14(Physical devices) and 12 & 14 simulator. Here is my observation. (notes)
  • 🟥 TEST_RESTORE_FROM_BACKGROUND (FAILED): I tested this issue with the attached "Keyman-18.0.59-alpha-test-11838" build on the Android 12 & 14 simulator & Android 13 physical device. Here is my observation. (notes)
Retesting Template
@keymanapp-test-bot retest TEST_RESTORE_FROM_BACKGROUND

Test Artifacts

keymanapp-test-bot[bot] avatar Jun 20 '24 03:06 keymanapp-test-bot[bot]

Test Results

  • TEST_ROTATIONS (PASSED): I tested this issue with the attached "Keyman-18.0.59-alpha-test-11838" build on the Android 14(Physical devices) and 12 & 14 simulator. Here is my observation.
  1. Installed the "Keyman-18.0.59.apk" file and gave all permissions to the application.
  2. Checked the "Enable Keyman as system-wide keyboard" and set the keyboard as the default keyboard box on the settings page.
  3. Open the Keyman app. Enable the "Predictions" and install the "Dictionary"
  4. Enter some sentences in the text area.(Keyboard appears in portrait view)
  5. Rotate the mobile portrait to landscape view.
  6. Open any app in the landscape view.
  7. Rotate the mobile landscape to a portrait view. It works well. Thank you.
  • TEST_RESTORE_FROM_BACKGROUND (FAILED): I tested this issue with the attached "Keyman-18.0.59-alpha-test-11838" build on the Android 12 & 14 simulator & Android 13 physical device. Here is my observation.
  1. Installed the "Keyman-18.0.59.apk" file and gave all permissions to the application.
  2. Checked the "Enable Keyman as system-wide keyboard" and set the keyboard as the default keyboard box on the settings page.
  3. Open the Keyman app. Enable the "Predictions" and install the "Dictionary"
  4. Enter some sentences in the text area.
  5. Open the Chrome browser and navigate to the "search" box.
  6. Click the home button on the mobile.
  7. Rotate the mobile portrait to landscape view.
  8. Click the return button on the mobile.
  9. Again, Open the Chrome browser and navigate to the "search" box.
  10. Click in the search box. Verify that the keyboard does not appear the first time.
  11. Open the Keyman app. Here, a blank space appears on the right side of the screen. I observed this behavior on the Android 12 and 14 simulators & Android 13 physical devices. Please refer to the screenshot below. Android 13 physical devices.

Android12_Simulator_LargeSize_4Seconds

Android14_Landscape_Keyman

https://github.com/keymanapp/keyman/assets/19683059/67f97afa-3599-4f1d-a59b-eae9094cab07

dinakaranr avatar Jun 20 '24 15:06 dinakaranr

11. Open the Keyman app. Here, a blank space appears on the right side of the screen. I observed this behavior on the Android 12 and 14 simulators & Android 13 physical devices. Please refer to the screenshot below.

Well, that's a new one. Huh.

jahorton avatar Jun 21 '24 01:06 jahorton

Abandoning this, as it's old, unmaintained, and had significant issues not present on master.

jahorton avatar Jan 20 '25 07:01 jahorton